Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xeno endgame content part 1: pylons and larva #3985

Merged
merged 18 commits into from
Aug 8, 2023

Conversation

morrowwolf
Copy link
Member

@morrowwolf morrowwolf commented Jul 24, 2023

About the pull request

This PR:

Allows xenos to capture comms relays after 90 minutes into the game.

Once a comms relay is captured, each comm relay gives 10% of the current hive total every five minutes. (Note: I'd like more impact, this is just part 1)

To capture a comms relay you must place a cluster nearby. This cluster then morphs into a pylon with CAS/mortar protection.

Explain why it's good for the game

After a certain point in the game it can stale due to sieging or otherwise failure for either side to want to fight. This should create urgency and change the focus of the round if stagnating.

Testing Photographs and Procedure

image

Changelog

🆑 Morrow, Sleepynecrons (beautiful sprites)
add: Xenos can now capture comms relays for bonuses after 90 minutes into the round.
/:cl:

@github-actions github-actions bot added Sprites Remove the soul from the game. Feature Feature coder badge labels Jul 24, 2023
@morrowwolf morrowwolf added the Work in Progress Will never be finished label Jul 24, 2023
code/modules/cm_aliens/structures/special/pylon_core.dm Outdated Show resolved Hide resolved
code/modules/cm_aliens/structures/special/pylon_core.dm Outdated Show resolved Hide resolved
code/game/machinery/telecomms/presets.dm Outdated Show resolved Hide resolved
code/modules/mob/living/carbon/xenomorph/xeno_defines.dm Outdated Show resolved Hide resolved
@Tarhalindur
Copy link

There should be some indication on the xeno examine text of the comms relay that you can do this, I think - especially since the changelog doesn't say how. Maybe there could also be a xeno announcement when the ability becomes available.

@morrowwolf
Copy link
Member Author

morrowwolf commented Jul 25, 2023

Not fully deleting when hijacking <- done
Increase resin ceiling range a bit <- done
Make resin hive/hardy ??? <- done (testing)
Cut overlay flick time in half, seems to be close to working correctly <- done
Forsaken should not be able to corrupt the towers, easier to make it so can't corrupt if in endgame probably <- done
Unique timer <- done
Cap on xeno size and percent gain rather than 1 per 5 minutes <- done
Review

@ihatethisengine
Copy link
Contributor

What stops xenos from not hijacking until they get as much larva as possible?

code/game/machinery/telecomms/presets.dm Outdated Show resolved Hide resolved
Comment on lines 15 to 21
var/obj/effect/alien/weeds/node/node
var/linked_turfs = list()

var/damaged = FALSE
var/plasma_stored = 0
var/plasma_required_to_repair = 1000
var/activated = FALSE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code doc your new vars here

code/modules/cm_aliens/structures/special/pylon_core.dm Outdated Show resolved Hide resolved
@morrowwolf
Copy link
Member Author

Usual disclaimer: Not trying to ignore review just don't want to go touching stuff before finalizing the direction I want to go after seeing it in game a bit.

Will get to review probably later this week, thank you guys you are the best 🙏

github-merge-queue bot pushed a commit that referenced this pull request Jul 26, 2023
# About the pull request

Comms no longer only on USMC minimap, now shown for all. (esp Xenos)

# Explain why it's good for the game

With PR #3985, Xenos now need to know where comms are. As such, it makes
sense for minimap to allow for more people to see the comms. I set it so
ALL can see it, but if we want it so only USMC and Xenos can see it,
that can be done.

# Changelog
:cl:
ui: Xenos (and others) now see comms relays on minimap
/:cl:
@morrowwolf morrowwolf removed the Work in Progress Will never be finished label Aug 6, 2023
Copy link
Member

@harryob harryob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nits

code/game/machinery/telecomms/presets.dm Outdated Show resolved Hide resolved
code/modules/cm_aliens/structures/special/pylon_core.dm Outdated Show resolved Hide resolved
@harryob harryob marked this pull request as draft August 7, 2023 13:51
@morrowwolf morrowwolf marked this pull request as ready for review August 8, 2023 04:53
@harryob harryob added this pull request to the merge queue Aug 8, 2023
Merged via the queue into cmss13-devs:master with commit e77c994 Aug 8, 2023
26 checks passed
cm13-github added a commit that referenced this pull request Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature Feature coder badge Sprites Remove the soul from the game.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants